search

wp-media / backwpup

BackWPup - WordPress Backup Plugin
https://backwpup.com
GNU General Public License v2.0
88 stars 36 forks source link

PHP Deprecation notice #101

Closed superpoincare closed 3 years ago

superpoincare commented 4 years ago

I am getting this error message in Query Monitor:

Non-static method BackWPup_Admin::admin_css() should not be called statically

image

Dinamiko commented 4 years ago

Hi @vijayaraghavanramanan,

can you please provide the steps to reproduce the issue and the versions of WordPress, PHP and BackWPup? thanks.

superpoincare commented 4 years ago

PHP version 7.1.13

Wordpress version 5.4

BackWPup version 3.7.1

Steps to reproduce: Install the plugin "Query Monitor" which by default has a menu item on top on activation. Then visit the front page, the menu turns orange, indicating a message. Click on that which opens the QM tool in bottom and see the message.

kraftner commented 3 years ago

This still seems to be an issue:

The issue is here:

https://github.com/inpsyde/backwpup/blob/bdb72dd8d51076d7e11bf9ce52e0f94e1246ca33/inc/class-adminbar.php#L21

BackWPup 3.8.0 has this in the Changelog

https://github.com/inpsyde/backwpup/blob/bdb72dd8d51076d7e11bf9ce52e0f94e1246ca33/changelog.txt#L14

but due to the whole release being in one commit I couldn't see if this was an incomplete fix or somehow just missed with the message in the Changelog being wrong.

cuongdcdev commented 3 years ago

this will be fixed in the next plugin update, for now, if you want, please download the patched plugin version here: https://www.dropbox.com/s/8jd8hv226wrqobl/backwpup-fix-warning.zip?dl=0