Add option to use path style for S3.

wp-media / backwpup

BackWPup - WordPress Backup Plugin

https://backwpup.com

GNU General Public License v2.0

88 stars 35 forks source link

Add option to use path style for S3. #58

Closed noplanman closed 5 years ago

noplanman commented 6 years ago

This PR adds a checkbox to allow the use of S3 instances which require a path style instead of subdomain style.

This is required for Minio, for example.

Fixes #57

noplanman commented 6 years ago

Arguably, a better solution would be to use an up-to-date version of the AWS SDK package.

Then it would be much easier to just add the use_path_style_endpoint parameter to the S3 client constructor/factory.

widoz commented 5 years ago

Hi @noplanman Thanks for the pull request, I had a problem to import the patch in the latest version (3.6.7), could you make the branch align the branch to the master?

noplanman commented 5 years ago

@widoz Ok, should work now :+1:

danielhuesken commented 5 years ago

Will be added in a other way with other things.