search

wp-media / backwpup

BackWPup - WordPress Backup Plugin
https://backwpup.com
GNU General Public License v2.0
88 stars 35 forks source link

Backup to azure not working, when TLS/HTTPS is forced in the backend #76

Closed a3rosol closed 5 years ago

a3rosol commented 6 years ago

Hi! As the title says, the backup to azure blob doesn't work (error 400) when the azure account has only allowed https connections. It appears, backwpup tries to connect via http

masterminduday commented 5 years ago

@inpsyde I too am facing the same issue. My Azure storage is only HTTPS and unable to upload backup. I also get 400 error code.

markheydon commented 5 years ago

Hi @a3rosol and @masterminduday,

I too got this error while researching the possibility of moving away from AWS S3 to Azure Storage. A quick hunt in the code I found the following comment around where the job was failing for me...

https causes an error SSL: Connection reset by peer that is why http

So I tested on one of my sites changing the 'http' to 'https' and it worked fine; no SSL error and the blob was uploaded to Azure as expected.

I have submitted a pull request (#80 -- pointless really as it's a one character change) in the hope the author will comment further on what the original issue was that prompted it to be hardcoded to use http, and hopefully get the issue fixed.

I can't say I am in favour of changing the Azure Storage account to insecure, so hopefully, something will now happen. If there is some issue somewhere around certain environments or something, maybe the answer is to add an option for secure or insecure rather than hardcode http and https?

Mark

jartes commented 5 years ago

I'm interested too about this issue. I'm having the same problem uploading backups to MS Azure. Thanks for solving it @markheydon :)

VaclavElias commented 5 years ago

Thank you @markheydon. This worked for me. I had to update my plugin manually. Hope it will be merged soon?

jartes commented 5 years ago

Submitted a new PR (#87) adding an option to choose between http and https :)