search

wp-media / backwpup

BackWPup - WordPress Backup Plugin
https://backwpup.com
GNU General Public License v2.0
88 stars 35 forks source link

Necessary/good to test for wp-compat on frontend? #78

Closed cfoellmann closed 3 years ago

cfoellmann commented 6 years ago

I just saw in Query monitor on one of my sites:

Query Abruffunktion Komponente Zeilen Zeit
SELECT option_value FROM mok_options WHERE option_name = 'backwpup_cfg_hash' LIMIT 1 BackWPup_System_Tests->is_wp_version_compatible() wp-content/plugins/backwpup/inc/class-system-tests.php:33 BackWPup::get_plugin_data() wp-content/plugins/backwpup/backwpup.php:190 get_site_option() wp-includes/option.php:1109 get_network_option() wp-includes/option.php:1244 get_option() wp-includes/option.php:98 Plugin: backwpup 1 0,0646

Is it really necessary to test that on the frontend? Or is it limited to logged in and admins?

widoz commented 5 years ago

Hi @cfoellmann thanks for reporting it, actually this should works only on admin. Need more inspection why the plugin data is executed also in the frontend.