search

wp-media / backwpup

BackWPup - WordPress Backup Plugin
https://backwpup.com
GNU General Public License v2.0
88 stars 36 forks source link

css version query string #93

Open superpoincare opened 4 years ago

superpoincare commented 4 years ago

The file main.min.css doesn't get cached as the query string changes every time.

Perhaps it has to do with the fact that this if condition is the reverse?

https://github.com/inpsyde/backwpup/blob/d928c57196ae32a51a8a3ee16d0a6c3038091742/inc/class-admin.php#L110

widoz commented 4 years ago

Hi @vijayaraghavanramanan Thanks for pointing out it. You're totally right the conditional should be switched.

I would also take the opportunity to improve this part by not asking for time but filemtime instead. We have the same advantages in develop mode + caching when the file does not change.

cc @Dinamiko @danielhuesken