search

wp-media / imagify-plugin

Speed up your website with lighter images without losing quality.
https://imagify.io
71 stars 25 forks source link

Fix PHP8-cURL Compatibility #540

Closed iCaspar closed 3 years ago

iCaspar commented 3 years ago

Fixes #539 .

Add a check for php8 CurlHandle object

iCaspar commented 3 years ago

@wp-media/qa - Acceptance criteria:

  1. Users of Imagify on PHP 8 installation should not get a Could not initialize a new cURL handle error when attempting to optimize images.
  2. Users of Imagify on PHP < 8 should not experience any changes.
  3. Regression test: We have removed what we believe to be a redundant error supression to handle when cURL is not available at all. In this case, users should see a cURL isn\'t installed on the server. error message in the Media Library (or other relevant) UI rather than a PHP fatal error. This should be regression-checked.
grantmucha commented 3 years ago

confirmed working, updated and tested Server Info : nginx/1.19.6 PHP Version : 8.0.0 Jnews 7.1.x