fix pricing table and coupon input

mostafa-hisham commented 3 years ago

fixes #557 fixes #556

iCaspar commented 3 years ago

Ready for @wp-media/qa

piotrbak commented 3 years ago

@mostafa-hisham When promo is set to all plans, the coupon is not applied at all, but the prices are crossed out:

The discount text is also not present at the end of the checkout process:

The 0 is crossed out:

mostafa-hisham commented 3 years ago

@piotrbak

@mostafa-hisham When the promo is set to all plans, the coupon is not applied at all, but the prices are crossed out:

FIXED

The discount text is also not present at the end of the checkout process:

this part is coming from "https://app.tst.imagify.io/#/plugin/0/0/15/wpr10/" in I think it is related to this issue <a href="https://github.com/wp-media/imagify/issues/1580">https://github.com/wp-media/imagify/issues/1580</a></p> <blockquote> <p>The 0 is crossed out: <img src="https://user-images.githubusercontent.com/26767037/125631417-e1fdbe1a-b0ce-4be5-80cc-7da89eff2b5d.png" alt="image" /> <img src="https://user-images.githubusercontent.com/26767037/125631461-f34c98f8-789d-45bb-ab7b-6e6bdba14eb8.png" alt="image" /></p> <p><strong>FIXED</strong></p> </blockquote> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/piotrbak"><img src="https://avatars.githubusercontent.com/u/26767037?v=4" />piotrbak</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>@mostafa-hisham Now it's possible to apply a promo coupon to the plan that's not in promotion. To reproduce:</p> <ol> <li>Promo is set to have only unlimited in promotion</li> <li>Go to checkout, choose Growth</li> <li>Add the promo coupon (<code>spring</code>) and click ok</li> <li>The coupon is applied</li> <li>Go to checkout, the checkout is not possible because the coupon is not valid.</li> </ol> <p><img src="https://user-images.githubusercontent.com/26767037/125642338-187a6caf-2888-4abb-a01a-6670fb2bba41.png" alt="image" /></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/mostafa-hisham"><img src="https://avatars.githubusercontent.com/u/29744252?v=4" />mostafa-hisham</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>@piotrbak please check if you can apply a promo coupon to the plan that's not in the promotion after this change</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

wp-media / imagify-plugin

fix pricing table and coupon input #593