wp-media / imagify-plugin

Speed up your website with lighter images without losing quality.
https://imagify.io
71 stars 25 forks source link

Fix/592 small css glitch in other media section #628

Closed joejoe04 closed 2 years ago

joejoe04 commented 2 years ago

closes #592

Fixes issues with the select and filter button display on the "Other Media" page including:

Corrects the select element padding so the text doesn't run into the down arrow icon at narrow widths and also so it matches the height of the filter button:

1

Fixes filter button padding at width of 782px and below so its height continues to match height of select elements:

2

Changes the top margin of select elements and filter buttons so they adapt with better spacing at narrower display widths:

3

Mai-Saad commented 2 years ago

Can see the initial problem fixed on chrome, FF, safari.

Note: All folders field width is dependent on selected folder path length i.e for longer path, the width of All folders field increase and corrupt in small screens, Can we fix this? (i.e we can truncate the path of older after a certain length maybe) will this be included in the current PR? @Tabrisrp @joejoe04 what do you think?

Screenshot from 2021-12-13 11-34-55

Screenshot from 2021-12-13 11-38-35

joejoe04 commented 2 years ago

@Mai-Saad Nice catch on the select element width with long folder names. I’ve added one more commit applying a max-width value to it and it now looks like this at narrow widths:

image

However, that doesn’t help with the option element inside with the folder names:

image

I tried doing some searching, but I’m not sure it’s possible to limit the width of these. If this is an issue we should fix, that may need a separate GH issue, where we could possibly do something like limit the values to a specific number of characters, but that could lead to some confusion possibly.

Interested if anyone else has an opinion on this.