Fix/586 remove WP Rocket banner when plugin installed (but inactive)

wp-media / imagify-plugin

Speed up your website with lighter images without losing quality.

https://imagify.io

71 stars 25 forks source link

Fix/586 remove WP Rocket banner when plugin installed (but inactive) #631

Closed markonikolic985 closed 2 years ago

markonikolic985 commented 2 years ago

Closes #586

Hide WP Rocket Banner when plugin is installed but not active.

Changed files:

views/page-settings.php to keep imagify-have-rocket CSS class so the main column has 100% width
views/page-rocket-ad.php to check if plugin exists (active or not)

Mai-Saad commented 2 years ago

Can see the fix on the settings page (currently if WPR is installed or activated, the Banner is not displayed). However, Can't check the Bulk Optimization page as after closing the banner while exploring on the trunk, it didn't appear again even after deleting transients.

Update: Tried another account, Banner removed from settings page but not from Bulk Optimization page. @markonikolic985 Can you please check this case? https://jmp.sh/Un0UdNm

iCaspar commented 2 years ago

Hey here @Mai-Saad I've added a tweak to hid the banner on the bulk page as well. Also, if you previously dismissed a banner, you will find in the db -> wp_usermeta table an entry for _imagify_ignore_ads that stores the dismissed status. If you remove that, it should reset the banner to the "as new" state.