wp-media / imagify-plugin

Speed up your website with lighter images without losing quality.
https://imagify.io
69 stars 24 forks source link

Added a fix for the lightbox #762

Open CrochetFeve0251 opened 7 months ago

CrochetFeve0251 commented 7 months ago

Description

Added a fix for the lightbox by not passing the wp attributes to the picture tag.

Fixes #758

Type of change

Please delete options that are not relevant.

Is the solution different from the one proposed during the grooming?

No.

Checklists

Generic development checklist

Test summary

If not, detail what you could not test.

Please describe any additional tests you performed.

vmanthos commented 7 months ago

@CrochetFeve0251 Thank you for the PR.

The issue has been fixed but there is a console error that's not there with trunk:

Uncaught TypeError: Cannot read properties of null (reading 'focus')

image

This can be seen here: https://vasilis.rocketlabsqa.ovh/wordpress-6-4-lightbox-implementation

  1. Click on the jellyfish picture.
  2. Close the lightbox using the x button or the picture itself.
  3. Check the console log.

Can you please check this? :pray: