wp-media / imagify-plugin

Speed up your website with lighter images without losing quality.

https://imagify.io

69 stars 24 forks source link

Fixes #789 Fix error displayed when using generate missing next-gen versions button #805

Closed Tabrisrp closed 3 months ago

Tabrisrp commented 4 months ago

Description

Remove avif as a supported mime type to prevent the error reported, as the format is not currently supported by the Imagick/GD implementation in WP (coming in 6.5).

Also update the ajax URL identifier for the generate missing next-gen versions in the JS file.

Fixes #789

Type of change

[x] Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

[x] I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
[x] I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

[x] I wrote self-explanatory code about what it does.
[x] I named variables and functions explicitely.
[x] I did not introduce unecessary complexity.

Observability

[x] I handled errors when needed.

Miraeld commented 4 months ago

Shouldn't this file be modified/updated as well ?

jeawhanlee commented 4 months ago

@Tabrisrp I did a small manual test with the PR branch and I got this error when I click on Generate missing next-gen images version:

Screenshot 2024-02-19 at 13 10 09

Tabrisrp commented 3 months ago

I can't replicate it, did you have AVIF conversion enabled or not?

jeawhanlee commented 3 months ago

I can't replicate it, did you have AVIF conversion enabled or not?

Avif was disabled when I checked this but with Avif enabled, I still get the error.

piotrbak commented 3 months ago

@jeawhanlee What kind of environment did you use? Was it a local or live one?

jeawhanlee commented 3 months ago

@piotrbak A local

piotrbak commented 3 months ago

@Tabrisrp Are we okay with this comment made by @Miraeld? https://github.com/wp-media/imagify-plugin/pull/805#issuecomment-1952300279 If that's okay, let's move forward with CR.

@jeawhanlee let's see if QA will be able to reproduce this problem, if it's there we should also check if it's a regression when comparing to the current trunk version.

Tabrisrp commented 3 months ago

Yes it's fine we can update the minified files at the end

Mai-Saad commented 3 months ago

@Tabrisrp Thanks for the PR. Got the same error mentioned by @jeawhanlee on both local and https://imagify.rocketlabsqa.ovh/ while AVIF is enabled or disabled. can you please check :pray: (working fine on trunk) Screenshot from 2024-02-22 14-41-00

Tabrisrp commented 3 months ago

It might be related to the fixes done in https://github.com/wp-media/imagify-plugin/pull/806