Miraeld commented 3 months ago

Description

Fixes #796

Documentation

User documentation

Fix the issue related to the auto-optimization on save while AVIF is being enable.

Technical documentation

When we save the Imagify settings, we get to a callback which will check if the AVIF is enable or not. If it is, we will start optimizing the images when AVIF is missing in order to generate these AVIF versions of images.

Type of change

[x] Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

[x] I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
[x] I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

[x] I wrote self-explanatory code about what it does.
[x] I wrote comments to explain why it does it.
[x] I named variables and functions explicitely.
[x] I protected entry points against unexpected inputs.
[x] I did not introduce unecessary complexity.

Observability

[x] I handled errors when needed.

Tabrisrp commented 3 months ago

There is some conflicts to fix after the merge of my PR to the main branch

jeawhanlee commented 3 months ago

@Miraeld Could you fix the codacy errors, they are mostly related to phpcs.

Miraeld commented 3 months ago

As noted by @Mai-Saad , if we run only this branch, we might get our file deleted.

However, merging this branch with this one fix the issue :)

So this PR requires https://github.com/wp-media/imagify-plugin/pull/807 :)

wp-media / imagify-plugin

Closes #796: Auto generation of AVIF on save #806