Closes #794 display the smaller size on image library data

[Khadreal]

Description

Display the smaller size of the image(avif)

Fixes #794

Documentation

User documentation

This will show the avif image size & percentage when available

Technical documentation

Explain how this code works. Diagram & drawings are welcomed.

Type of change

• [x] Enhancement (non-breaking change which improves an existing functionality).

New dependencies

N/A

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Checklists

Feature validation

• [x] I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
• [x] I triggered all changed lines of code at least once without new errors/warnings/notices.
• [x] I implemented built-in tests to cover the new/changed code.

Code style

• [x] I wrote self-explanatory code about what it does.
• [x] I wrote comments to explain why it does it.
• [x] I named variables and functions explicitely.
• [x] I did not introduce unecessary complexity.

[Khadreal]

I think we should go further on this one, updating this method and other methods in the class that reference webp, to make it work with the new implementation (using next-gen). This would also require to update the interface.

If I understand correctly, we should update the method from webp to nextgen ?

[Tabrisrp]

Yes, update all occurrences of webp to nextgen. I see there is also a use of imagify_path_to_webp() that should be updated in this class for example.

[Mai-Saad]

@Khadreal Thanks for the PR. please find exploratory note below:

• when upload image while avif is off, we arenot generating webP by default
• when enable avif after that, we arenot generating avif for uploaded images in previous step can you please check? (those points were working on the main feature branch)

[Khadreal]

@Khadreal Thanks for the PR. please find exploratory note below:

• when upload image while avif is off, we arenot generating webP by default
• when enable avif after that, we arenot generating avif for uploaded images in previous step can you please check? (those points were working on the main feature branch)

The branch has been updated to the latest feature branch

[Mai-Saad]

@Khadreal Thanks for the PR. working as in trunk after merging main branch to the PR locally while image have only webp.

Note: we have some discussion about sizes here (probably it isnot always the smallest on trunk), however, the agreed expected shall be in separate GH as it's the case on trunk.

Update: as per slack discussion, we shall display here the size of avif , if not exist then webp, if not exist then optimized => now we display in media library new size as per enabled option. which doesn't meet this update from slack. @Khadreal can you please check? steps: 1- avif enabled 2- upload image => avif created and new size =that of avif 3- disable avif => webp created 4- check media library => new size = webp size instead of avif

/cc @piotrbak

[Khadreal]

This PR https://github.com/wp-media/imagify-plugin/pull/851 once merge will fixed the failing test error

[MathieuLamiot]

@Khadreal should this go back to ready for review, or there are still work needed here?

[Khadreal]

@Khadreal should this go back to ready for review, or there are still work needed here?

I'll move it, done with the work but didn't move it because of the test failing

[Mai-Saad]

@Khadreal Thanks for the update. Please find exploratory note below:

• Can see the following error for medium size image [14-Mar-2024 12:29:32 UTC] PHP Warning: Undefined array key "optimized_size" in /home/mai/Local Sites/imagifynginx6/app/public/wp-content/plugins/imagify-plugin/classes/Optimization/Data/AbstractData.php on line 309 in the following scenario: 1- install and activate imagify 2- upload med size image attached 3- enable avif

or 1- activate avif 2- upload the same image

can you please check?

Note: in general, related test case https://wpmediaqa.testrail.io/index.php?/cases/view/15271

[Khadreal]

Got this error, wondering if you're seeing something like this as well. This is when avif is not enable.

[Khadreal]

794

Got this error, wondering if you're seeing something like this as well. This is when avif is not enable.

My last update fixed this too

[Mai-Saad]

@Khadreal Thanks for the update, fixed in both scenarios mentioned above but can see problem if we refresh admin after scenario 2 i.e 1- install and activate imagify 2- enable avif 3- upload the image => avif created and no error 4- refresh media page , the warning is there

in log can see [18-Mar-2024 09:52:12 UTC] PHP Warning: Undefined array key "full@imagify-webp" in /home/mai/Local Sites/imagifynginx6/app/public/wp-content/plugins/imagify-plugin/classes/Optimization/Data/AbstractData.php on line 314

note: it happens with any optimized image not just the previous one screen-capture (88).webm

[Khadreal]

Fixed. please check again. Sorry for the back and forth

[Mai-Saad]

@Khadreal Thanks for the update. Working fine now with the following note (which is fine as per https://wp-media.slack.com/archives/CU0F6EGQ1/p1709546156479809?thread_ts=1709458320.636499&cid=CU0F6EGQ1)

• if we manually deleted next-gen, the displayed size won't change even after refresh media page (i.e displayed size is that of avif, then manually delete the avif, the displayed size still is that of avif)