wp-media / imagify-plugin

Speed up your website with lighter images without losing quality.

https://imagify.io

69 stars 24 forks source link

Fixes #833 Delete all next-gen versions on restore original image #835

Closed Tabrisrp closed 3 months ago

Tabrisrp commented 3 months ago

Description

Correctly delete all next-gen versions on restore original image by passing the second parameter of the methods to true

Fixes #833

Type of change

[x] Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

[x] I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
[x] I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

[x] I wrote self-explanatory code about what it does.
[x] I did not introduce unecessary complexity.

Mai-Saad commented 3 months ago

jeawhanlee commented 3 months ago

Testing in progress...

jeawhanlee commented 3 months ago

Thank you for the PR @Tabrisrp. During execution of test plan, with webp versions available and avif enabled, whenreoptimize with lossless compression is clicked the webp versions are deleted and avif created, While on trunk webp versions is untouched, Do we need to fix this @piotrbak ?

piotrbak commented 3 months ago

Yes, that sounds like a regression. @Tabrisrp the lossless/smart compression is related to the image optimization only, not the generation of webp/avif, right?

Tabrisrp commented 3 months ago

The lossless level also applies to the next-gen versions, so it makes sense to delete and re-create them too

piotrbak commented 3 months ago

@Tabrisrp Looks like @Mai-Saad and @jeawhanlee were correct here. Currently in 2.2 we're not touching the version that's not enabled.

Is this a big effort to redo this change?

Tabrisrp commented 3 months ago

It would mean to go back to the previous state, so the issue this PR is fixing would not be fixed.

Re-optimizing process is first restore the original, then optimize again with new settings, so it uses the same underlying restore methods.

MathieuLamiot commented 3 months ago

@piotrbak how can we align on the expected behavior to move forward? Should we set up a quick call this afternoon or not needed?

piotrbak commented 3 months ago

@MathieuLamiot I think we're okay with what @Tabrisrp explained.

@Mai-Saad We'll need to update the TCs