wp-media / imagify-plugin

Speed up your website with lighter images without losing quality.
https://imagify.io
73 stars 27 forks source link

Update Next-Gen gallery compatibility for AVIF support #846

Closed remyperona closed 8 months ago

remyperona commented 8 months ago

Description

Update Next-Gen gallery compatibility for AVIF support

Type of change

Code style

Mai-Saad commented 8 months ago

Exploratory test notes Next-gen gallery plugin Already on 2.1.3 (may need separate GH) 1- At next gen gallery, expand /collapse view details isnot working 2- Click restore original image, then click optimize again, will show that image is already optimized instead of optimizing it (tested with large image, and with med image but with medium image webP won't be created for main image 'only for thumb' while delete webp option is displayed in NGG page) 3- optimizing in nextgen gallery view will keep loading till manual refresh the page 4- image not optmized in media but optimized on next gen gallery download (34)

5- open bulk page at next -gen gallery will result in [19-Mar-2024 09:03:17 UTC] PHP Deprecated: Function _imagify_display_bulk_page() is deprecated since version 1.7! Use Imagify_Views::get_instance()->display_bulk_page() instead. in /home/mai/Local Sites/imagifynginx6/app/public/wp-includes/functions.php on line 6078 => added GH https://github.com/wp-media/imagify-plugin/issues/862

6- Generated next-gen is yes for this image although webp no generated for main image marchmed1

7- Restore original isnot clickable while generate webp link is there Screenshot from 2024-03-19 15-31-10

8- The new size > original size and both != that in media library (if generate webP is off , new size < original but still != that in media library) Screenshot from 2024-03-20 11-40-49 Screenshot from 2024-03-20 11-43-53

9- Progress bar in bulk optimization of next gen gallery is 0 while the chartbar is != 0 Screenshot from 2024-03-20 11-49-41

10- imagify all keeps loading after being clicked in next-gen bulk optimization although % is 100 till manually refresh the page

on 2.2.0.1 already https://github.com/wp-media/imagify-plugin/issues/863

on 2.2.1

Mai-Saad commented 8 months ago

Test report testrail-report-587.pdf failed test due to the point mentioned on 2.2.1 above ..

piotrbak commented 8 months ago

@Mai-Saad As we talked, we'll be good here. 1st and 5th point will deserve the separate GH, the same for the one you meantioned as the last point on 2.2.1