wp-media / imagify-plugin

Speed up your website with lighter images without losing quality.
https://imagify.io
73 stars 26 forks source link

After updating to 2.2 WP Rocket's WebP addon doesn't detect Imagify as a WebP compatible plugin #850

Closed alfonso100 closed 8 months ago

alfonso100 commented 8 months ago

Before submitting an issue please check that you’ve completed the following steps: yes - Made sure you’re on the latest version yes - Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug After updating to 2.2 WP Rocket's WebP addon doesn't detect Imagify as a WebP plugin anymore

To Reproduce Steps to reproduce the behavior:

  1. Update Imagify to 2.2
  2. On WP Rocket, go to the WebP addon
  3. See the message: We have not detected any compatible WebP plugin!

Expected behavior we should detect Imagify as a WebP compatible plugin

Screenshots image

Additional context ticket https://secure.helpscout.net/conversation/2533421582/479330?folderId=273761

Acceptance Criteria (for WP Media team use only) Clear instructions for developers, to be added before the grooming

MathieuLamiot commented 8 months ago

Status update / summary:

There are two aspects to be dealt with separately:

Case 1:

Case 2:

@piotrbak, can I let you see the prioritiy for case 2? (this issue) Thanks

piotrbak commented 8 months ago

@MathieuLamiot I think we could close this issue and leave only this one opened. What do you think? https://github.com/wp-media/wp-rocket/issues/6468

MathieuLamiot commented 8 months ago

@piotrbak There are 2 issues to fix in 2 different places. One in Imagify, the other in WP Rocket. Unless you decide not to fix case 2, we should keep this issue open.

Update from Piotr here: If the effort here is more than [XS] we could close the issue, 1st scenario is the priority. We'd ask customers to update both plugins.

remyperona commented 8 months ago

Isn't case 2 fixed by the update done in 2.2.0.1?

MathieuLamiot commented 8 months ago

That's the question raised here. Maybe, I don't know. It needs to be checked. What I am worried about is that we brought back display_webp option but do we keep its value updated?

remyperona commented 8 months ago

It won't be updated anymore, so is the expectation to keep it updated based on convert to AVIF enabled, and the filter?

MathieuLamiot commented 8 months ago

The requirement is that with WP Rocket 3.15.9 and Imagify 2.2.0.1+, the 3rd party WebP display must be accurate. That's the only way I see to keep backward compatibility with WP Rocket 3.15.9 and before ; otherwise the 3rd-party display won't be correct ; right? As @piotrbak mentioned, if it's more than [XS] (and I would add, if it complicated the codebase too much), we will discard this issue.