The .htaccess was always being modified while saving Imagify settings.
This PR fix this behavior to modify the .htaccess only when there is a change in the settings.
Technical documentation
We just check if the previous value is the same as the current one before changing the .htaccess.
Type of change
Delete options that are not relevant.
[x] Bug fix (non-breaking change which fixes an issue).
Checklists
Feature validation
[x] I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
[x] I triggered all changed lines of code at least once without new errors/warnings/notices.
Documentation
[x] I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
[x] The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
[x] I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.
Code style
[x] I wrote self-explanatory code about what it does.
[x] I wrote comments to explain why it does it.
[x] I named variables and functions explicitely.
[x] I protected entry points against unexpected inputs.
[x] I did not introduce unecessary complexity.
[x] I listed the introduced external dependencies explicitely on the PR.
[x] I validated the repo-specific guidelines from CONTRIBUTING.md.
Mai-Saad
commented
8 months ago
Description
Fixes #837
Documentation
User documentation
The
.htaccesswas always being modified while saving Imagify settings. This PR fix this behavior to modify the.htaccessonly when there is a change in the settings.Technical documentation
We just check if the previous value is the same as the current one before changing the
.htaccess.Type of change
Delete options that are not relevant.
Checklists
Feature validation
Documentation
Code style