Closed wordpressfan closed 7 months ago
I tried to add unit tests at least for this one but I found that in the WP class uses the filesystem so we need to get the virtual filesystem idea
we need to replace it with
$this->filesystem = imagify_get_filesystem();
and then mock this function inside the virtual filesystem trait as we use in WPR here:
The tests are not ready as a framework, so I'll leave it to be handled properly in the other created issue.
Description
Fixes #871
I can't reproduce the issue on my local, I tried to insert new media size with integer name but this didn't throw this error at all, I hope I can get the credentials from the escalated case working to see how this error happens.
I found the following line of code inside their theme functions.php
If u take a look at the shared error message, you will see this 1920 size coming as integer
Then I got this snippet in our test site and tried uploading a huge image but I can't see the avif image generated for this size (
1920X1080
) but again can't see any error in the log.I'm mentioning the snippet here so QA can add while they validate this case.
Documentation
User documentation
Explain how this code impacts users.
Technical documentation
Explain how this code works. Diagram & drawings are welcomed.
Type of change
Delete options that are not relevant.
New dependencies
List any new dependencies that are required for this change.
Risks
List possible performance & security issues or risks, and explain how they have been mitigated.
Checklists
Feature validation
Documentation
Code style
Observability
Risks