search

wp-media / imagify-plugin

Speed up your website with lighter images without losing quality.
https://imagify.io
69 stars 24 forks source link

Add Unit Test to Imagify #880

Open Khadreal opened 4 weeks ago

Khadreal commented 4 weeks ago

Unit tests are absent for this PR: https://github.com/wp-media/imagify-plugin/pull/878. To avoid delaying the PR for 2.2.2, I'm creating this note so we can keep track of it.

CrochetFeve0251 commented 4 weeks ago

@Khadreal would it be possible to create integration tests for the Pr instead of unit tests?

wordpressfan commented 4 weeks ago

Add to that, we need to add the VFS support to our tests like what we do in WP Rocket, check my comment here:

https://github.com/wp-media/imagify-plugin/pull/877#issuecomment-2066283005

MathieuLamiot commented 2 weeks ago

After discussing with @wordpressfan, it could be a good opportunity to combine this with WP Launchpad: instead of copy/pasting files between repositories, we could have a common library for all this, so that we have the same test framework on all our plugins. So, to tackle this issue, it would be good to discuss with @CrochetFeve0251 to get up to speed on WP Launchpad and see how we could:

MathieuLamiot commented 3 days ago

@wordpressfan @CrochetFeve0251 Do you have an update on the targeted approach here? Thanks

wordpressfan commented 3 days ago

I met last Friday with @CrochetFeve0251 and @Tabrisrp to talk about this and we have like a plan of moving some parts of code from WPR to wp-media/phpunit repository so we can use this package across all of our plugins.

@CrochetFeve0251 can u plz share the points that we discussed so we all are aligned.

CrochetFeve0251 commented 3 days ago

@wordpressfan I created an issue on the related repository: https://github.com/wp-media/phpunit/issues/30