Create a New Block in Imagify

wp-media / imagify-plugin

Speed up your website with lighter images without losing quality.

https://imagify.io

73 stars 26 forks source link

Create a New Block in Imagify #895

Closed Agathemed closed 3 weeks ago

Agathemed commented 3 months ago

Description and assets available here.

jeawhanlee commented 1 month ago

Scope a solution ✅

First, we need to update this section content to fit with the description and mockup provided above.
Next for each of the plugins stated, we need to check first if they are:
- Installed: Check if there's a related path in the plugins directory for the said plugin.
- Activated: Check that plugin is activated, we can do this using is_plugin_active
If plugin is not active:
- Install plugin using the Plugin_Upgrader class with the install method passing the plugin url.
- Finally activate plugin using the activate_plugin function

We will need to create a class to manage this actions, this should be in the event driven architecture(EDA) that we already introduced

Estimate the effort ✅

[M]

@Agathemed I do have a question, we have WP Rocket ad right now on imagify though with an option to dismiss. Should that be removed in favour of this new UI?

Miraeld commented 1 month ago

Looks good to me, could be nice to get the answer from @wp-media/marketing before starting work on it as @jeawhanlee did ask a question. It would avoid back and forth if the answer is positive.

Agathemed commented 1 month ago

@jeawhanlee No change on the WP Rocket banner for now. Thx

hanna-meda commented 3 weeks ago

@wp-media/marketing, The updates are now complete and ready for your attention. Thank you!

Agathemed commented 3 weeks ago

How can we take a look at the updates, please?

hanna-meda commented 3 weeks ago

Hello @Agathemed,

Sorry, I hadn't thought to provide you with a test site earlier. Here is one prepared for you with the latest changes: test site link (credentials in Bitwarden).

Agathemed commented 3 weeks ago

Why is Imagify removed from the menu here? Image

hanna-meda commented 3 weeks ago

I’m sorry for the back and forth. I noticed another small fix needed for the “GET IT NOW” CTA from WP Rocket: the link currently opens in the same tab, but it should open in a new tab, as it does for all other “Learn More” links. I’ll update the PR with this fix and let you know as soon as it’s ready.

hanna-meda commented 3 weeks ago

@Agathemed, everything is ready now. Please check on this other site (credentials in Bitwarden), as the first one provided did not meet the PHP version required for some of our plugins.

Agathemed commented 3 weeks ago

Perfect! 👌