wp-media / imagify-plugin

Speed up your website with lighter images without losing quality.

https://imagify.io

73 stars 26 forks source link

Closes #2884 Upgrade plan link in admin bar #899

Closed remyperona closed 1 month ago

remyperona commented 1 month ago

Description

Fixes #2884

Add an upgrade plan link in the admin bar for free users with quota < 20%

Type of change

[x] Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Free account with more than 20% quota remaining
Display the imagify admin bar sub-menu
Upgrade plan link is displayed
Clicking on link opens the subscription popup

upgrade-plan

Technical description

Documentation

Display the button if free user and quota > 20%

Mandatory Checklist

Code validation

[x] I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
[x] I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

[x] I wrote a self-explanatory code about what it does.
[x] I protected entry points against unexpected inputs.
[x] I did not introduce unnecessary complexity.

Mai-Saad commented 1 month ago

@Tabrisrp Thanks for the PR.

currently, the upgrade plan link is displayed when the remaining quota for the starter (free) user is <= 20% ==> It shall be displayed when the free account has a remaining quota > 20%. Can you please check? :pray: (confirmed with @marija-nikolic )
if we click the upgrade link, we will have an empty loading popup. can you please check :pray: or let us know if anything needs to be done so popup data is displayed

marija-nikolic commented 1 month ago

I've noticed there is a mistake here. If we have a pink banner displayed, we don't need a green "Upgrade plan" button. You have details on this Notion page

I've just discussed it with Mai.

marija-nikolic commented 1 month ago

@Tabrisrp @Mai-Saad Did we fix this issue here with having both upgrade options (green and pink)?

Mai-Saad commented 1 month ago

@Tabrisrp @Mai-Saad Did we fix this issue here with having both upgrade options (green and pink)?

Yes can see it fixed now Screenshot from 2024-10-07 13-38-57

upgrade link
popup after clicking link still keeps loading with me, @Tabrisrp can you please add screenshot of popup

remyperona commented 1 month ago

Updated the JS min file that was missing

Mai-Saad commented 1 month ago

upgrade style is good now while script_debug is false

Screenshot from 2024-10-10 15-46-25

The banner is displayed when click upgrade (the new banner is in another PR as per @Tabrisrp )