wp-media / imagify-plugin

Speed up your website with lighter images without losing quality.

https://imagify.io

73 stars 26 forks source link

Closes #2886: Replace the existing "What Plan Do I Need" banner with the new one #904

Closed jeawhanlee closed 1 month ago

jeawhanlee commented 1 month ago

Description

Fixes https://github.com/wp-media/imagify/issues/2886 Users now see all plans on the upgrade modal at first glance.

Type of change

[x] Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

No Issue to reproduce

Technical description

Documentation

Updated plans modal and the plan switcher

New dependencies

N/A

Risks

N/A

Mandatory Checklist

Code validation

[x] I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
[x] I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

[x] I wrote a self-explanatory code about what it does.
[x] I did not introduce unnecessary complexity.

jeawhanlee commented 1 month ago

New Modal Design: Screenshot 2024-10-03 at 17 27 39

Old Modal Design: Screenshot 2024-10-03 at 17 28 59 Screenshot 2024-10-03 at 17 29 14

Mai-Saad commented 1 month ago

NewBanner free: newbanner_free

New popup: newPopUp_2 newPopup_1

No green banner for growth and infinite user :heavy_check_mark:

marija-nikolic commented 1 month ago

Hi team, please make sure that we are using the arrow from Font Awesome 6 pro on the buttons. I've just double-checked what Célia (our designer) is using.

Please check the pink upgrade banners too.

jeawhanlee commented 1 month ago

Both banners now having the expected arrow icon in button.

Screenshot 2024-10-08 at 14 01 47

Screenshot 2024-10-08 at 14 02 51

marija-nikolic commented 1 month ago

Both banners now having the expected arrow icon in button.

I am sorry @jeawhanlee, I missed this comment. The design of the pink banner is strange, it doesn't reflect what we should have. Could you please check? We validated everything with @Mai-Saad on the retreat.

marija-nikolic commented 1 month ago

NewBanner free:

New popup:

No green banner for growth and infinite user ✔️

Sorry for the delay in checking the new popups. In the end we won't have any changes, the only thing we should improve is the alignment of /MONTH: You can use the alignment on https://app.imagify.io/subscription/ as a reference:

Mai-Saad commented 1 month ago

GreenBanner PinkBanner Adminbar when pinkBanner state (same already on production) redadminbar_noImagifyPage

Mai-Saad commented 1 month ago

Adminbar when pinkBanner state (same already on production)

This is fixed now on PR AdminWIthremianing 20%

Mai-Saad commented 1 month ago

Merged dev to the PR local and here are screenshots of banners Green banner Settings page Screenshot from 2024-10-15 10-06-50

Bulk page BulkPageRemaining 20%

Pink banner settings page settingsRemaining20%

bulk page Screenshot from 2024-10-15 10-40-37

Click upgrade now popUp From admin bar link Screenshot from 2024-10-15 10-43-06

From green banner it keeps loading (@jeawhanlee can you please check this :pray:)

upgrade_nowIn BulkPage

Mai-Saad commented 1 month ago

upgrade link from the green banner is working now Screenshot from 2024-10-16 16-03-09

However, can see this in debug.log when click upgrade btn in admin bar or green banner after fresh install [16-Oct-2024 13:09:36 UTC] PHP Deprecated: round(): Passing null to parameter #1 ($num) of type int|float is deprecated in /var/www/new.rocketlabsqa.ovh/htdocs/wp-content/plugins/imagify-plugin/inc/classes/class-imagify-files-stats.php on line 408 ===> added new GH about that as it's already on trunk https://github.com/wp-media/imagify-plugin/issues/909