wp-media / imagify-plugin

Speed up your website with lighter images without losing quality.
https://imagify.io
73 stars 26 forks source link

Conflict with gravity forms noconflict mode #919

Open wordpressfan opened 1 week ago

wordpressfan commented 1 week ago

Before submitting an issue please check that you’ve completed the following steps:

Describe the bug

When gravity forms noconflict mode is enabled, the imagify pricing modal is showing on the page without any styling.

To Reproduce Steps to reproduce the behavior:

  1. Install and activate gravity forms
  2. Install and activate imagify plugin
  3. Go to gravity forms settings page from the admin menu
  4. Enable no conflict mode and save the form by clicking on Save Changes button
  5. You will see the modal in the footer without any styling.

Expected behavior It should behave correctly and hide the modal by default.

Screenshots

Image

Additional context

Slack discussion: https://wp-media.slack.com/archives/C045P1RA2/p1731310030013799

Possible solutions:

  1. Insert inline CSS to hide the modal style="display: none;"
  2. Use the following filters to add our styles/scripts into no conflict mode:

https://docs.gravityforms.com/gform_noconflict_scripts/ https://docs.gravityforms.com/gform_noconflict_styles/

Acceptance Criteria (for WP Media team use only) Clear instructions for developers, to be added before the grooming

saranshj4 commented 1 week ago

https://secure.helpscout.net/conversation/2759170188/522428/ https://secure.helpscout.net/conversation/2757655775/522142/ https://secure.helpscout.net/conversation/2758516745/522301/ https://secure.helpscout.net/conversation/2758064944/522219/

MathieuLamiot commented 2 days ago

dev-team-escalation to consider as well for the fix.

Khadreal commented 1 day ago

The PR created here fixed this but needs to be tested