Closed MathieuLamiot closed 3 months ago
lcp_no_dimension_svg on PSI lcp is <img class="logo-main scale-with-grid svg" src="https://discuss-assets.s3.amazonaws.com/original/3X/1/9/19823cc1f1f887d707…" data-retina="" data-script-height="" alt="Porty Cleaning Services">
, But sometimes our o/p wasn't matching PSI. Anyway, makes sense if it's bigger to be the LCP though.
lcp_no_dimensions_picture on PSI LCP is <img src="/wp-content/rocket-test-data/images/lcp/testjpg.jpg" alt="GFG" data-width="">
which is 2nd image however, expected there now on trunk of e2e is single image while it shall be all images within that markup
<picture>
<source media="(max-width: 700px)" srcset="<?php echo content_url().'/rocket-test-data/images/lcp/testavif.avif' ?>">
<source media="(max-width: 450px)" srcset="<?php echo content_url().'/rocket-test-data/images/lcp/testPng.png' ?>">
<img src='/wp-content/rocket-test-data/images/lcp/testjpg.jpg' alt="GFG" data-width="" >
</picture>
Recommend full review on expected o/p for both mobile/desktop
From this discussion: https://wp-media.slack.com/archives/CUKB44GNN/p1717692117226009 I think we are good to remove the svg test for now.
On mobile:
Maybe also (no removed for now):