wp-media / wp-rocket-e2e

Playwright E2E testing repo
GNU General Public License v3.0
0 stars 0 forks source link

Enhancement/healthcheck command#110 #112

Closed Khadreal closed 4 months ago

Khadreal commented 5 months ago

Description

Add a command to check if ssh is working after setting up e2e, this basically ssh to the server and run wp --info

Fixes #110

Documentation

User documentation

Explain how this code impacts users.

Technical documentation

Explain how this code works. Diagram & drawings are welcomed.

Type of change

New dependencies

I installed chalk dependency

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Checklists

Feature validation

Documentation

Code style

jeawhanlee commented 4 months ago

Thanks for the PR @Khadreal, it works as expected. However, console log on the CLI could be more detailed. For example we should have a log when the browser setup starts and validate throughout this process with relative log if setup fails or not as well as a log for the auth as well. This is a refinement I believe and an enhancement can be opened for this so we can allow this move forward. @MathieuLamiot What do you think?

MathieuLamiot commented 4 months ago

💯 Can you open a dedicated issue with those ideas? 🙏 Thanks