removed the ‘after’ property from minify_css and minify_js

[hanna-meda]

Description

Fixes #127

Documentation

Since 3.16.3 for both the Minify CSS and Minify JS options, there is no additional pop-up anymore after ticking the option to validate its activation. Solution: Removed the after property of elements minify_css and minify_js in src/common/selector.ts.

See #127 for more details

[jeawhanlee]

@MathieuLamiot This is fine when testing with previous_versions as 3.16.3 but there's no backward compatibility for older WPR versions, so testing with those versions will fail.

We should Instead bail when the selector is not visible in activateFromPopUp WDYT?

[MathieuLamiot]

We discussed at a retro a few weeks away that we would not maintain backward compatibility, but tag versions instead. Should this change?

I don't see a use-case in which we would need new tests to be backward compatible

[jeawhanlee]

Yes typically, there should be no use case for this, but it comes up occasionally. I guess we are good to go here then

[hanna-meda]

waiting for locator('text=Activate minify CSS') to be visible & waiting for locator('text=Activate minify JavaScript') to be visible errors are no longer present when running smoke tests.

Confirming this as fixed. Complete smoke results after commit: hanna.e2e.smoke_results.txt