wp-media / wp-rocket-e2e

Playwright E2E testing repo
GNU General Public License v3.0
0 stars 0 forks source link

LRC visual regression on live templates #137

Closed Mai-Saad closed 1 month ago

Mai-Saad commented 2 months ago

Scenario: Shouldn't cause visual regression when visiting x template Given: 3.17+ is active And: Visit x page When: clear cache And: visit the page then: no visual regression compared to nowprocket

Templates: delayjs_1.3_live_template.php delayjs_68_live_template.php page lcp_6647_live.php lcp_live_4_template.php lcp_live_test_span.php rucss_5213_template.php template 4787.php lrc_will_site.php

MathieuLamiot commented 2 months ago

Looks like we might already have all the needed code, and we just need to put together test scenarios with list of files to test against?

See the step I must not see any visual regression

jeawhanlee commented 2 months ago

Scope a solution ✅

Estimate the effort ✅

[S]

For Added context, we need to make some changes to the way we create references, as all urls in SCENARIO_URLS will be created as references which for most regression tests, we will not tests all references but rather just a few, take for example this current grooming, if we are to add the new templates to the SCENARIO_URLS we will have other templates there in the object that will not be tested for that test cycle simple because we don't need to.

I added an issue for this here @MathieuLamiot

MathieuLamiot commented 2 months ago

Thanks @jeawhanlee. I added your issue to the cooldown board. Up to @wp-media/qa-team and you to decide what needs to be prioritized first among those E2E visual regression issues :)