wp-media / wp-rocket-e2e

Playwright E2E testing repo

GNU General Public License v3.0

0 stars 0 forks source link

Closes #80: ATF fixture does not use base url of test suite #81

Closed jeawhanlee closed 4 months ago

jeawhanlee commented 4 months ago

Description

This PR converts hardcoded e2e ATF urls in the fixture to relative.

Fixes #80

Documentation

User documentation

Explain how this code impacts users.

Technical documentation

Explain how this code works. Diagram & drawings are welcomed.

Type of change

[x] Bug fix (non-breaking change which fixes an issue).

New dependencies

None

Risks

None

Checklists

Feature validation

[ ] I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
[ ] I triggered all changed lines of code at least once without new errors/warnings/notices.
[ ] I implemented built-in tests to cover the new/changed code.

Documentation

[ ] I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
[ ] The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
[ ] I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

[ ] I wrote self-explanatory code about what it does.
[ ] I wrote comments to explain why it does it.
[ ] I named variables and functions explicitely.
[ ] I protected entry points against unexpected inputs.
[ ] I did not introduce unecessary complexity.
[ ] I listed the introduced external dependencies explicitely on the PR.
[ ] I validated the repo-specific guidelines from CONTRIBUTING.md.

Observability

[ ] I handled errors when needed.
[ ] I wrote user-facing messages that are understandable and provide actionable feedbacks.
[ ] I prepared ways to observe the implemented system (logs, data, etc.).

Risks

[ ] I explicitely mentioned performance risks in the PR.
[ ] I explicitely mentioned security risks in the PR.