search

wp-media / wp-rocket-e2e

Playwright E2E testing repo
GNU General Public License v3.0
0 stars 0 forks source link

LCP Test does not fail when no result in DB #82

Closed jeawhanlee closed 5 months ago

jeawhanlee commented 5 months ago

Before submitting an issue please check that you’ve completed the following steps:

Describe the bug When running lcp tests, if there are not results in DB after page visits, test will log output but will not fail.

To Reproduce Steps to reproduce the behavior:

  1. Set the viewport dimension in test to something unsupported, this will cause the beacon to bail.
  2. See logs in CLI (No result from database for url)
  3. Tests will pass in the end.

Expected behavior Tests should fail when there is no result in DB.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

Acceptance Criteria (for WP Media team use only) Clear instructions for developers, to be added before the grooming

MathieuLamiot commented 5 months ago

discussed here and blocking #71