search

wp-media / wp-rocket-helpers

🚀 Helper plugins for specific use cases with WP Rocket. ☝️ TEST BEFORE USE! ☝️
https://wp-rocket.me/support/
GNU General Public License v2.0
202 stars 68 forks source link

Excluding doesn't seem to work #7

Closed TomberWolf closed 6 years ago

TomberWolf commented 6 years ago

Hey Rocket Team,

I tried to use this addon to exclude Easy FancyBox because it doesn't work with this setting. I just want to make sure that I understand it correctly.

Here are my settings:

wp-rocket-static-exclude-defer-js.php.txt

(.txt extension is just to attach the php file because github doesn't allow .php files)

arunbasillal commented 6 years ago

@TomberWolf The code looks right. Are those files still deferred after clearing the cache?

If so, please open a support here: https://wp-rocket.me/support/ or from the plugin interface. One of us will definitely help you out :)

TomberWolf commented 6 years ago

I think so, because the lightbox isn't working. I will give it an additional try and let you know. If it won't work I will open a ticket at wp-rocket.me.

arunbasillal commented 6 years ago

Sounds good, please include a link to this GitHub issue so we can keep track of the conversation :)