wp-media / wp-rocket-helpers

🚀 Helper plugins for specific use cases with WP Rocket. ☝️ TEST BEFORE USE! ☝️

https://wp-rocket.me/support/

GNU General Public License v2.0

202 stars 68 forks source link

Deleting the rucss change parameters helper #89

Closed joejoe04 closed 4 months ago

joejoe04 commented 4 months ago

Description

Fixes #83

In an effort to simplify and organize the helpers repo, we are removing this helper: https://github.com/wp-media/wp-rocket-helpers/tree/32ad8323d4c52aff9745613ce13aaacf115380a6/rucss/wp-rocket-rucss-change-parameters

We have the WP Rocket | Change Parameters, which takes care of what this helper does plus the parameters for Preload as well.

Checklists

Feature validation

[ ] I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
[ ] I triggered all changed lines of code at least once without new errors/warnings/notices.
[ ] I implemented built-in tests to cover the new/changed code.

Documentation

[ ] I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
[ ] The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
[ ] I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

[ ] I wrote self-explanatory code about what it does.
[ ] I wrote comments to explain why it does it.
[ ] I named variables and functions explicitely.
[ ] I protected entry points against unexpected inputs.
[ ] I did not introduce unecessary complexity.
[ ] I listed the introduced external dependencies explicitely on the PR.
[ ] I validated the repo-specific guidelines from CONTRIBUTING.md.

Observability

[ ] I handled errors when needed.
[ ] I wrote user-facing messages that are understandable and provide actionable feedbacks.
[ ] I prepared ways to observe the implemented system (logs, data, etc.).

Risks

[ ] I explicitely mentioned performance risks in the PR.
[ ] I explicitely mentioned security risks in the PR.