search

wp-media / wp-rocket

Performance optimization plugin for WordPress
https://wp-rocket.me
GNU General Public License v2.0
701 stars 218 forks source link

jQuery Migrate removed with WP5.5 => remove feature? #2995

Closed gevcen closed 4 years ago

gevcen commented 4 years ago

Dear,

In WordPress 5.5, the jQuery Migrate is removed, the feature in wp rocket then becomes uncessary anymore or may even cause issues on sites not having it and who still enable the feature?

Kr

remyperona commented 4 years ago

Hi,

jQuery migrate is removed from 5.5, but it's coming back with an updated version on WP 5.6 at the same time the included jQuery version is updated to 3.x. So that option, while useless for a time for anyone on WP 5.5, will be useful again with the next major release of WP.

Following that, the updated version of jQuery migrate is planned to be removed with WP 5.7, and at that time we will re-evaluate the need of the option, depending on how fast our users migrate to the latest. Not everyone in our userbase is using the most recent version of WP for whatever reason, so we have to take that into account too.

gevcen commented 4 years ago

Alright, good to know but for those who upgrade to WP 5.5, I assume it's better to disable the feature "Remove jQuery Migrate" before upgrading right? thanks

remyperona commented 4 years ago

The difference will be negligeable, it won't break anything to have it on, and it will also not speed up the process noticeably to have it off.

It's up to you if you want to disable it before upgrading/when you're on 5.5.