Disabling Heartbeat causes Missing Dependencies error in Query Monitor

NataliaDrause commented 3 years ago

Before submitting an issue please check that you’ve completed the following steps:

Made sure you’re on the latest version - yes
Used the search feature to ensure that the bug hasn’t been reported before - yes

Describe the bug When Heartbeat settings are set to "disable", query monitor reports the following error: Missing Dependencies wp-auth-check example.com wp-includes/js/wp-auth-check.min.js heartbeat (missing), wp-i18n

If settings are set to "reduce activity", the error disappears.

To Reproduce Steps to reproduce the behavior:

Instal and activate Query Monitor plugin.
Set Heartbeat settings in WP Rocket to "disable" position.
Check the Query Monitor for the error. Screenshot:

Expected behavior No errors

Additional context Query monitor developers comment:

The script should be overridden rather than deregistered. WP Engine used to do this too, there's an old thread here: https://wordpress.org/support/topic/suppress-presistent-errors-ex-broken-dependencies-wp-auth-check-on-wp-engine/

Backlog Grooming (for WP Media dev team use only)

[ ] Reproduce the problem
[ ] Identify the root cause
[ ] Scope a solution
[ ] Estimate the effort

alpercelilhankucuk commented 3 years ago

hi, for some unknown reason i am getting this error. can you help me? also my website's admin panel is very slow. wp-auth-check.min.js error here. I'm not using wp-rocket. Thank you very much in advance for your interest.

Ekran Resmi 2021-06-11 14 58 30

Ekran Resmi 2021-06-11 15 05 54

moazam1 commented 3 years ago

Same issue. Please help.

Mai-Saad commented 3 years ago

Note: for retesting we can use the following settings (heartbeat enabled but activities are disabled) Screenshot from 2021-07-05 11-50-51

moazam1 commented 3 years ago

My settings are same like yours but still no luck.

girlie commented 3 years ago

Uhtredtb commented 3 years ago

Yes, it still got this issue, confirmed.

please someone fix this.

Thanks

NataliaDrause commented 3 years ago

EmSixTeen commented 3 years ago

+1, this is still a thing, 🙂

remyperona commented 2 years ago

Reproduce the issue ✅

Reproduced

Identify the root cause ✅

We deregister the script when the settings is on disabled, but it's used as a dependency for other files, so it's going to cause this error.

Scope a solution ✅

The solution is in 2 parts:

Create an empty heartbeat.js file in our assets/js folder.
When we deregister the core heartbeat script, enqueue the empty one with the same handle to replace it (Engine/Heartbeat/HeartbeatSubscriber:maybe_disable())

Estimate the effort ✅

Effort [XS]

worldwildweb commented 2 years ago

related https://secure.helpscout.net/conversation/1916333415/347773/ but in wpr 3.11.3 The issue occurs only when Behavior in backend is set to Reduce Activity

wp-media / wp-rocket