WebP cache disabled when EWWW is enabled (without serving WebP)

wp-media / wp-rocket

Performance optimization plugin for WordPress

https://wp-rocket.me

GNU General Public License v2.0

690 stars 215 forks source link

WebP cache disabled when EWWW is enabled (without serving WebP) #4372

Open DahmaniAdame opened 3 years ago

DahmaniAdame commented 3 years ago

Before submitting an issue please check that you’ve completed the following steps:

[x] Made sure you’re on the latest version 3.9.4
[x] Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug In a domain using Cloudflare, when EWWW is enabled without any option to serve WebP, WP Rocket has the WebP Cache grayed out.

To Reproduce Steps to reproduce the behavior:

Use a website with Cloudflare managing the DNS
Enable EWWW without any option to server WebP
See error

Expected behavior WebP Cache should be usable when none of WebP serving options is enabled.

Screenshots N/A

Additional context N/A

Backlog Grooming (for WP Media dev team use only)

[ ] Reproduce the problem
[ ] Identify the root cause
[ ] Scope a solution
[ ] Estimate the effort

Mai-Saad commented 3 years ago

On the test site, our webP is enabled if we disabled everything related to webP at the EWWW plugin.

DahmaniAdame commented 3 years ago

I had a chance to do more testing. I can confirm that the issue only happens when Cloudflare is detected by EWWW. I manually removed all Cloudflare checks on EWWW. This resulted in bringing back the WebP Cache on WP Rocket Updated the issue. @Mai-Saad the issue can only be seen if Cloudflare is enabled.

WordPresseur commented 2 years ago

viobru commented 2 years ago

milllan commented 1 year ago

@DahmaniAdame Hi. How did you remove Cloudflare checks on EWWW IO? I am having the same issue with Cloudflare \EWWW IO combo

edit: common.php, function ewwwio_is_cf_host() to return false ...

DahmaniAdame commented 1 year ago

@milllan sorry for the delay.

common.php, function ewwwio_is_cf_host() to return false ...

Yes. That's it :)

sandyfigueroa commented 3 months ago

suzoutlet commented 3 months ago