Open jeawhanlee opened 1 month ago
👋 @Tabrisrp As part of this PR, maybe you could get the occasion to improve test coverage of the frontend controller. We had a quick fix here (see Slack https://wp-media.slack.com/archives/CUT7FLHF1/p1724228398435879). Being able to change this logic without breaking any tests could be a sign that some stuff could be better covered I think :)
Using feature/lrc
[]
, no optimization is applied but hashes remain, shouldn't we remove hashes in this case? @piotrbak @MathieuLamiot 1st point discussed here Pending product confirmation of the expected behavior, and an issue to tackle it.
Description
This is a continuation of the Frontend task here which already caters for adding hashes to eligible elements for urls that don't have LRC data in DB. So to be done after #6835
Moving forward to complete the frontend task in a case where LRC data exists in DB In
WP_Rocket\Engine\Optimization\LazyRenderContent\Frontend::Controller::optimize
data-wpr-lazyrender
attribute to ithtml
to avar
html
to add style to lazy render content just before the closinghead
tagoptimize
method and the value returned back to the buffer.Acceptance Criteria
Additional information
This should be done after this is completed