wp-media / wp-rocket

Performance optimization plugin for WordPress
https://wp-rocket.me
GNU General Public License v2.0
691 stars 215 forks source link

JS minification breaks WP Recipe Maker pro plugins #7000

Open smerriman opened 3 hours ago

smerriman commented 3 hours ago

With Minify JS on and WP Recipe Maker Pro active, minification is breaking JS files by deleting large parts of the script.

To Reproduce Install WP Recipe Maker Pro Visit a page with a recipe where the public-pro.js is output Notice that the minified script is cut off after {test:[/\sedg\//i

Expected behavior The script should not be broken by the minifier.

Additional context I did notice an old thread about this - https://github.com/wp-media/wp-rocket/issues/2974 - but it was from 4 years ago and marked as closed. WP Recipe Maker is a very popular plugin, so I've had to go through all of my clients sites and add exclusions - but this will be affecting a lot of people.

webtrainingwheels commented 3 hours ago

This is a related case: https://secure.helpscout.net/conversation/2719039223/514571?folderId=377611 (for internal use only) Excluding /wp-content/plugins/wp-recipe-maker-premium/dist/public-premium.js fixed multiple issues.