Automatic Lazy Rendering: 500 error in browser console if dom extension is disabled - Class "DOMDocument" not found

alfonso100 commented 1 week ago

Before submitting an issue please check that you’ve completed the following steps: Yes - Made sure you’re on the latest version Yes - Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug A 500 error appears in the browser console, the website is still functional but cache and optimizations are not applied.

This is related to Automatic Lazy Rendering and its usage of PHP dom extension When the dom extension (https://www.php.net/en/dom) is disabled in the server, it triggers the error here: https://github.com/wp-media/wp-rocket/blob/73488699424f726bef28dbf2c934340efcab8e47/inc/Engine/Optimization/LazyRenderContent/Frontend/Processor/Dom.php#L81

Error log: 5818 FastCGI sent in stderr: "PHP message: PHP Fatal error: Uncaught Error: Class "DOMDocument" not found in /wp-content/plugins/wp-rocket/inc/Engine/Optimization/LazyRenderContent/Frontend/Processor/Dom.php:81 To solve they need to enable the dom extension in PHP

To Reproduce Steps to reproduce the behavior:

Disable DOM extension in PHP
Visit the frontend of the site
See the 500 error console error

Expected behavior We should check if DOM extension is enabled or not, and:

show a warning to the users in the backend
Avoid the fatal error

Additional context Ticket 1: https://secure.helpscout.net/conversation/2720908346/514956?folderId=2683093 Ticket 2: https://secure.helpscout.net/conversation/2723174345/515454?folderId=2683093 Slack thread: https://wp-media.slack.com/archives/C43T1AYMQ/p1727853713650349

Acceptance Criteria (for WP Media team use only) Clear instructions for developers, to be added before the grooming

Adrianadla commented 2 days ago

webtrainingwheels commented 1 day ago

wp-media / wp-rocket

Automatic Lazy Rendering: 500 error in browser console if dom extension is disabled - Class "DOMDocument" not found #7002