Miraeld commented 2 weeks ago

Description

Fixes #7111

It changes the folder where fonts are being loaded from. Now it will look into /wp-content/cache/fonts/google-fonts/ instead of /wp-content/cache/fonts/

Type of change

[x] Enhancement (non-breaking change which improves an existing functionality).
[x] Sub-task of #7063

Detailed scenario

Just load a page with google fonts, and check the added tag to load the local file.

Technical description

Documentation

N/a

New dependencies

N/a

Risks

N/a

Mandatory Checklist

Code validation

[x] I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
[x] I triggered all changed lines of code at least once without new errors/warnings/notices.
[x] I implemented built-in tests to cover the new/changed code.

Code style

[x] I wrote a self-explanatory code about what it does.
[x] I protected entry points against unexpected inputs.
[x] I did not introduce unnecessary complexity.
[x] Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

codacy-production[bot] commented 2 weeks ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for a6e21f55ea869b87f5947131537ec2337ec30ff5[^1]	:white_check_mark: 100.00% (target: 50.00%)

Coverage variation details

| | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (a6e21f55ea869b87f5947131537ec2337ec30ff5) | Report Missing | Report Missing | Report Missing | | | Head commit (cd1f13dc42108da92765a646ec07288a15b83e4b) | 38279 | 16777 | 43.83% | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `

Diff coverage details

| | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#7112) | 1 | 1 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more} [^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Khadreal commented 1 week ago

Closing this for now, the issue is resolved here https://github.com/wp-media/wp-rocket/pull/7083

wp-media / wp-rocket

Closes #7111: Change the folder where fonts are being laoded #7112