Support Net 4.5 outside of netstandard

wp-net / WordPressPCL

This is a portable library for consuimg the WordPress REST-API in (almost) any C# application

MIT License

338 stars 129 forks source link

Support Net 4.5 outside of netstandard #155

Closed ri0ter closed 5 years ago

ri0ter commented 5 years ago

Hey, what do you think about supporting net45 as an additional TargetFrameworks and allow lower version of Newtonsoft.Json? My problem is that I'm using net 4.5 and cannot install WordPressPCL because I'm using Newtonsoft.Json version 6.x (cannot upgrade due to many other dependencies relying on it).

I've already tested that solution (with a lower version of Newtonsoft.Json as a conditional dependency) and it works fine.

ThomasPe commented 5 years ago

I haven't really looked into supporting additional TargetFrameworks, but I'd gladly look at a PR if this can be done easily without impacting other frameworks.

ri0ter commented 5 years ago

I've tested it again and noticed that I've been using wrong version (few commits behind master). In #147 there was a change that breaks older versions of Newtonsoft.Json. So at this point, I think you can close this issue.