search

wp-net / WordPressPCL

This is a portable library for consuimg the WordPress REST-API in (almost) any C# application
MIT License
337 stars 129 forks source link

Support jwt-auth #214

Closed christianfrick closed 3 years ago

christianfrick commented 4 years ago

Dear all I'd like to contribute the support for the plugin https://wordpress.org/support/plugin/jwt-auth/ since the original plugin https://wordpress.org/support/plugin/jwt-authentication-for-wp-rest-api/ seems to be obsolete and not maintained anymore. I do already have a working code. Where shall I commit it to? Can you please create me a branch for the PR? Cheers Christian

ThomasPe commented 4 years ago

Hey, cool stuff! Feel free to create a PR against the master branch. We do need to make sure that we don't break the old auth way, though.

christianfrick commented 4 years ago

Hi @ThomasPe It seems like you first need to create a branch on which I can push my changes. Can you please create jwt-auth-support for me and grant access to it? Thanks

ThomasPe commented 4 years ago

I can create a branch, no problem. But have you tried forking the whole project and making a PR from there after you added your changes? Should be the easiest way and how it's usually done.

christianfrick commented 4 years ago

All fine. I'm just not used to GitHub. The PR #216 is available, but testing which supports both plugins is not implemented yet. Please find more details in the PR description.

topcatarg commented 3 years ago

Do you need help wih this? I saw that the last PR was rejected... What else do you need for this to work? This could be handly with some desktop App I'm making for a client...

ThomasPe commented 3 years ago

Hey, the PR didn't pass the integration tests yet as we have to adjust those for the new code. That means the WordPress docker installation that the code is being tested against needs to be adjusted as well. I'll look into it, but can't make any promises how fast I can do it. Feel free to look at it yourself as well. https://github.com/wp-net/wordpress-docker-compose

lkenner commented 3 years ago

Hey buddies, is is integrated yet? Still get this error #213

EDIT: Saw that it's just not in Nuget available. Copied it- thanks 👍

ThomasPe commented 3 years ago

It's on nuget now, sorry for the delay!

christianfrick commented 3 years ago

Awesome, thanks a lot @ThomasPe

bajecogem83 commented 3 years ago

Thank you ☺️