Closed christianfrick closed 3 years ago
Hey, cool stuff! Feel free to create a PR against the master branch. We do need to make sure that we don't break the old auth way, though.
Hi @ThomasPe
It seems like you first need to create a branch on which I can push my changes. Can you please create jwt-auth-support
for me and grant access to it? Thanks
I can create a branch, no problem. But have you tried forking the whole project and making a PR from there after you added your changes? Should be the easiest way and how it's usually done.
All fine. I'm just not used to GitHub. The PR #216 is available, but testing which supports both plugins is not implemented yet. Please find more details in the PR description.
Do you need help wih this? I saw that the last PR was rejected... What else do you need for this to work? This could be handly with some desktop App I'm making for a client...
Hey, the PR didn't pass the integration tests yet as we have to adjust those for the new code. That means the WordPress docker installation that the code is being tested against needs to be adjusted as well. I'll look into it, but can't make any promises how fast I can do it. Feel free to look at it yourself as well. https://github.com/wp-net/wordpress-docker-compose
Hey buddies, is is integrated yet? Still get this error #213
EDIT: Saw that it's just not in Nuget available. Copied it- thanks 👍
It's on nuget now, sorry for the delay!
Awesome, thanks a lot @ThomasPe
Thank you ☺️
Dear all I'd like to contribute the support for the plugin https://wordpress.org/support/plugin/jwt-auth/ since the original plugin https://wordpress.org/support/plugin/jwt-authentication-for-wp-rest-api/ seems to be obsolete and not maintained anymore. I do already have a working code. Where shall I commit it to? Can you please create me a branch for the PR? Cheers Christian