search

wp-net / WordPressPCL

This is a portable library for consuimg the WordPress REST-API in (almost) any C# application
MIT License
337 stars 129 forks source link

Allow use of WordPressClient together with HttpClientFactory #215

Closed kant2002 closed 3 years ago

kant2002 commented 3 years ago

@ThomasPe did you see my PR? any objection to the change?

ThomasPe commented 3 years ago

I saw it and added some feedback in the code

kant2002 commented 3 years ago

@ThomasPe I did not see anything. Where can it be? no review, and nothing in "Files Changed" section

ThomasPe commented 3 years ago

There should be some review comments right above these ones. I only can see the app view right new, can later check again in the browser.

kant2002 commented 3 years ago

My magic ball tells me that you do not press button "Submit Review". 😄

ThomasPe commented 3 years ago

Quite possibly, haven't used that yet 🙈 Of course I can't do that in the app, will do asap when I'm back home

ThomasPe commented 3 years ago

here we go :D

kant2002 commented 3 years ago

Thanks

On Tue, Sep 22, 2020 at 14:45 Thomas Pentenrieder notifications@github.com wrote:

Merged #215 https://github.com/wp-net/WordPressPCL/pull/215 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wp-net/WordPressPCL/pull/215#event-3792118967, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAPKN3CMC3RBKFQX46IC5TSHBP3RANCNFSM4QLSIWYQ .