search

wp-net / WordPressPCL

This is a portable library for consuimg the WordPress REST-API in (almost) any C# application
MIT License
337 stars 129 forks source link

Sorting is not honored when getting Users #224

Closed hinnerkweiler closed 1 year ago

hinnerkweiler commented 3 years ago

While trying to get a list of most recent registered Users for a Wordpress site I think I found a bug (hoping I understood the querybuilder correctly):

How to Reproduce:

var query = new WordPressPCL.Utility.UsersQueryBuilder(); query.Context = WordPressPCL.Models.Context.Edit; query.OrderBy = WordPressPCL.Models.UsersOrderBy.RegisteredDate; query.Order = WordPressPCL.Models.Order.DESC; query.PerPage = 100;

var result = await client.Users.Query(query,true);

What I expected: With WordPressPCL.Models.Order.DESC the first element returned should be the most recent registered user

What I got: first element returned was the oldest User (followed by the following oldest 99 users)

Why I belive it is a bug in WordpressPCL and not Wordpress: var result = await client.CustomRequest.Get<IEnumerable<WordPressPCL.Models.User>>("wp/v2/users?per_page=100&orderby=registered_date&order=desc&context=edit",false,true); leads to the expected result.

Assumption: query.Order = WordPressPCL.Models.Order.DESC goes unnoticed using UsersQueryBuilder

And to not only have a bug reported:

ThomasPe commented 3 years ago

Thanks for the detailed report, appreciate it. I'll try to look at it asap.