search

wp-papi / papi

:rocket: WordPress Page Type API with custom fields
https://wp-papi.github.io
MIT License
263 stars 32 forks source link

[bug] - Property/Text : nl2br #199

Closed nlemoine closed 8 years ago

nlemoine commented 8 years ago

What happened

Using a regular text field: 

papi_property( [
    'title'       => 'Some text',
    'type'        => 'text',
    'slug'        => 'some_text',
]),

When using the_papi_field, line breaks should be converted to <br /> tags by default but are actually escaped: &lt;br /&gt;

What I expected

Line breaks should be converted to <br /> tags but should not be escaped.

Problem

There's a contradiction with text property settings.

In order to allow nl2br to work, allow_html has to be set to false: https://github.com/wp-papi/papi/blob/master/src/properties/class-papi-property-text.php#L19

But if allow_html is set to false, the value is escaped: https://github.com/wp-papi/papi/blob/master/src/properties/class-papi-property-text.php#L57

Thus escaping the <br /> tags produced by nl2br.

What versions of softwares are you using?

frozzare commented 8 years ago

Thanks, fixed and will be out shortly.