wp-papi / papi

:rocket: WordPress Page Type API with custom fields
https://wp-papi.github.io
MIT License
263 stars 32 forks source link

papi_ajax blocked when using FORCE_SSL_ADMIN on non SSL site #213

Closed zombiefredrik closed 7 years ago

zombiefredrik commented 7 years ago

What I expected

papi_ajax to work in admin when doing conditionals (bool show as per example)

What happened instead

papi_ajax call was blocked since it was doing the request to get_bloginfo( 'url' ) and I have define('FORCE_SSL_ADMIN', true);

Steps to reproduce

set bloginfo url to http and turn on SSL as above in wp-config. paste the sample code from conditionals in docs.

Proposed fix

Change row 34 - function ajax_url() in class-papi-admin-ajax.php from $url = esc_url( trailingslashit( get_bloginfo( 'url' ) ) . 'papi-ajax/' ); to $url = esc_url( trailingslashit( home_url( '/' , is_ssl() ? 'https' : 'http' ) ) . 'papi-ajax/' );

What versions of softwares are you using?

frozzare commented 7 years ago

Thanks, fixed in all branches and will be out in next patch version!