File property: notice undefined property

wp-papi / papi

:rocket: WordPress Page Type API with custom fields

https://wp-papi.github.io

MIT License

263 stars 32 forks source link

File property: notice undefined property #217

Closed nlemoine closed 7 years ago

nlemoine commented 7 years ago

Description

Undefined property notice.

Steps to reproduce

Add a file property
Load and select a file (an mp4 video in my case, don't know if it matters)
Save

Page should now show a notice mentioning "undefined property on line 187" (in 3.1.18, line 185 on master) because, for a reason I didn't check, file isn't set.

What versions of softwares are you using?

Papi: 3.1.18
WordPress: 4.7.2

frozzare commented 7 years ago

Hm. Can't reproduce this with a image file or a excel file. But we can add a check that checks if file->file exists before it's used.

nlemoine commented 7 years ago

I checked again, this issue happens with an mp4 file. You can download a sample one here.

frozzare commented 7 years ago

Looks like the file property value isn't set on some files, since basename works with urls we can just set file property value to url and get the same output.