search

wp-shortcake / shortcake-bakery

A fine selection of shortcodes for WordPress
42 stars 16 forks source link

Transform protocol-less `src` to `https` instead of `http` #127

Closed danielbachhuber closed 8 years ago

danielbachhuber commented 8 years ago

If we're provided a protocol-less URL, we can safely assume it supports https

See #107

danielbachhuber commented 8 years ago

@goldenapples #reviewmerge

goldenapples commented 8 years ago

I don't think we want to do this for all tags, do we? This might work for script tags, but an https iframe on an http page will cause problems with postmessage communication.

I think it would make more sense to store the url field as protocol-less if that's how it's provided to us.

danielbachhuber commented 8 years ago

This might work for script tags, but an https iframe on an http page will cause problems with postmessage communication.

Touche. Let's :football: