Add height options to Silk shortcode

wp-shortcake / shortcake-bakery

A fine selection of shortcodes for WordPress

42 stars 16 forks source link

Add height options to Silk shortcode #132

Closed danielbachhuber closed 8 years ago

danielbachhuber commented 8 years ago

Fixes #105

danielbachhuber commented 8 years ago

@goldenapples #reviewmerge

goldenapples commented 8 years ago

Looks good, other than failing tests. I wondered briefly if it would be worthwhile to set a max-height for mobile. An 800px high, full-width scrollable iframe on a 480px tall mobile screen is a navigational impossibility. But I couldn't think of an obvious way of doing it here...