search

wp-shortcake / shortcake-bakery

A fine selection of shortcodes for WordPress
42 stars 16 forks source link

Properly parse YouTube shortcodes on preview #148

Closed danielbachhuber closed 8 years ago

danielbachhuber commented 8 years ago

See #145

danielbachhuber commented 8 years ago

@goldenapples #reviewmerge

goldenapples commented 8 years ago

Only comment I have is that this kind of unescaping seems like pretty common functionality that maybe should be handled in parse_url(). But that can be done in a later refactor when we start to see where it's necessary.

danielbachhuber commented 8 years ago

But that can be done in a later refactor when we start to see where it's necessary.

Yeah. I thought about doing adding the logic deeper, but didn't want to run into any unexpected edge cases. Seemed better to make a localized fix for now.

montchr commented 8 years ago

:clap: