wp-shortcake / shortcake-bakery

A fine selection of shortcodes for WordPress

42 stars 16 forks source link

Use Instagram API oEmbed endpoint to get embed HTML #164

Open montchr opened 8 years ago

montchr commented 8 years ago

162

Based on the approach utilized by Jetpack.

TODO

[x] Cache API response
[x] Fix broken hidecaption attribute
[ ] Fix tests

montchr commented 8 years ago

Not sure why hidecaption isn't present in $attrs, as I believe I have it implemented the same way as checkboxes on other shortcodes. Might be related to https://github.com/wp-shortcake/shortcake/issues/564? I'll come back to this after working on caching.

montchr commented 8 years ago

Okay, I have a cached implementation ready for review. It uses wp_oembed_get(), which means that it won't work with the shortcodes that aren't listed as default providers in WP, unless we filter oembed_providers.

montchr commented 8 years ago

With 9fe321e, hidecaption is now present in shortcode, but it has no effect on the oEmbed response. Looking into it.