Update composer PHPCS version to prevent dependency fail

davisshaver commented 7 years ago

Should result in passing build again.

Excludes vendor, tests, and node_modules from PHPCS.

davisshaver commented 7 years ago

Ah I see that this is the version bump that included some of the new rules. I can go through this and clean up for new standards.

davisshaver commented 7 years ago

Hm looks like we have a PHP notice in the tests too.

PHP Notice:  /tmp/wordpress-tests-lib/includes/../data/themedir1 is not readable in /tmp/wordpress/wp-includes/theme.php on line 471
PHP Stack trace:
PHP   1. {main}() /home/travis/.phpenv/versions/5.3.29/bin/phpunit:0
PHP   2. PHPUnit_TextUI_Command::main() /home/travis/.phpenv/versions/5.3.29/bin/phpunit:722
PHP   3. PHPUnit_TextUI_Command->run() phar:///home/travis/.phpenv/versions/5.3.29/bin/phpunit/phpunit/TextUI/Command.php:104
PHP   4. PHPUnit_TextUI_Command->handleArguments() phar:///home/travis/.phpenv/versions/5.3.29/bin/phpunit/phpunit/TextUI/Command.php:114
PHP   5. PHPUnit_TextUI_Command->handleBootstrap() phar:///home/travis/.phpenv/versions/5.3.29/bin/phpunit/phpunit/TextUI/Command.php:622
PHP   6. PHPUnit_Util_Fileloader::checkAndLoad() phar:///home/travis/.phpenv/versions/5.3.29/bin/phpunit/phpunit/TextUI/Command.php:792
PHP   7. PHPUnit_Util_Fileloader::load() phar:///home/travis/.phpenv/versions/5.3.29/bin/phpunit/phpunit/Util/Fileloader.php:42
PHP   8. include_once() phar:///home/travis/.phpenv/versions/5.3.29/bin/phpunit/phpunit/Util/Fileloader.php:58
PHP   9. require() /home/travis/build/wp-shortcake/shortcake-bakery/tests/bootstrap.php:19
PHP  10. require_once() /tmp/wordpress-tests-lib/includes/bootstrap.php:92
PHP  11. wp_templating_constants() /tmp/wordpress/wp-settings.php:392
PHP  12. get_template_directory() /tmp/wordpress/wp-includes/default-constants.php:343
PHP  13. get_theme_root() /tmp/wordpress/wp-includes/theme.php:305
PHP  14. get_raw_theme_root() /tmp/wordpress/wp-includes/theme.php:545
PHP  15. get_theme_roots() /tmp/wordpress/wp-includes/theme.php:644
PHP  16. search_theme_directories() /tmp/wordpress/wp-includes/theme.php:361
PHP  17. trigger_error() /tmp/wordpress/wp-includes/theme.php:471
Notice: /tmp/wordpress-tests-lib/includes/../data/themedir1 is not readable in /tmp/wordpress/wp-includes/theme.php on line 471

davisshaver commented 7 years ago

Added https://github.com/wp-shortcake/shortcake-bakery/pull/210/commits/650cd1f2584fd7fb82cbdd7940cb5fba298c4f68 to address PHP notice

Probably good for a review/merge if you're up to it @goldenapples

wp-shortcake / shortcake-bakery

Update composer PHPCS version to prevent dependency fail #210